prepend goTag directive on struct tags and omit overridden duplicate struct tags per #2514 #2533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Coffman <steve@khanacademy.org>
StevenACoffman
changed the title
StevenACoffman
force-pushed
the
valllabh_master
branch
from
6c55ce2
to
6195c43
Compare
Signed-off-by: Steve Coffman <steve@khanacademy.org>
StevenACoffman
force-pushed
the
valllabh_master
branch
from
6195c43
to
c83aa08
Compare
StevenACoffman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #2514, and without this PR,
GoTagFieldHookjust appends new tags, so@goTagwill not override an existing tag.Ideally it should override existing tag, since the sole purpose of the
@goTagdirective is to give control to user.In this PR, the
removeDuplicateTagshelper func is introduced to fix #2514This PR was originally authored by @valllabh in #2531 but I have adjusted it slightly.
I have: